ability to derive Item key from item data #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to make an async direct dom modification to components that I return from
renderSuggestion
and I'm creating a ref to them, but I'm finding that at times they end up pointing to old dom elements. I think without a key being specified on<Item />
, old elements are being recycled.What this PR does is allows you to include a
key
property in the data returned fromonSuggestionsFetchRequested
which would then be used as thekey
prop on the<Item />
component.I tested my use case with this change and it fixes my issue. No more unexpected/recycled DOM elements being referenced.
npm run build
to see that you didn't break anythingSorry, it is failing for me, but I don't know exactly what the problem is. Something with the prettier syntax?