Fix Attribute Errors #980
Merged
Fix Attribute Errors #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tal attribute error thrown by the backend on filtered runtime status.
Pyifan
requested changes
Aug 10, 2023
| @@ -0,0 +1 @@ | |||
| Fixed silent exception thrown by the UI when attempting a rerun of a single testcase with an active filter. | |||
There was a problem hiding this comment.
Merge the 2 news fragment? they read very similar to me.
| entries[child["name"]] = {} | ||
| # NOTE: we ignore assertions (DEFAULT category) and testcases | ||
| for child in entry.get("entries", []): | ||
| if child["category"] in ("DEFAULT"): |
There was a problem hiding this comment.
I don't think we shall rely on the category of child. Can we check the category of the entry upfront, as the stop condition for this recursive function?
There was a problem hiding this comment.
Let me check I remember, having some weird scenario, but perhaps with the update to frontend that is gone as well.
kn-ms
approved these changes
Aug 14, 2023
Pyifan
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
There are two attribute errors related to the interactive UI with filter expression feature. One is a silent exception thrown on rerun of single testcases on a missing length attribute. The other is related to running a single testcase where the filtered runtime status was not implemented.
Solution description
Added proper handling for these scenarios and an additional test for running a single testcase with an API call.
Checklist: