Fix/suppress certain exceptions during app stop #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenyu-ms
force-pushed
the
kill-proc-cont
branch
from
a9a1624
to
d7d268f
Compare
zhenyu-ms
force-pushed
the
kill-proc-cont
branch
from
d7d268f
to
6528a41
Compare
Pyifan
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
it might be to strict to ensure app terminated normally, after all a killed app during env shutdown does no harm. here we loose the constraint
Solution description
add extra class var for suppressible exceptions (by type ofc)
Checklist: