Feature/dependencies accept remote driver #1144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenyu-ms
force-pushed
the
remote-driver-dep
branch
from
003746a
to
b91e431
Compare
Pyifan
reviewed
Nov 4, 2024
| @@ -573,9 +573,7 @@ def add_remote_service(self, remote_service: RemoteService): | |||
| remote_service.start() | |||
|
|
|||
| def _stop_remote_services(self): | |||
|
|
|||
| for name, rmt_svc in self.remote_services.items(): | |||
| self.logger.info("Stopping Remote Server %s", name) | |||
yuxuan-ms
reviewed
Nov 4, 2024
|
|
||
| for name, rmt_svc in self.remote_services.items(): | ||
| self.logger.info("Stopping Remote Server %s", name) | ||
| for _, rmt_svc in self.remote_services.items(): |
There was a problem hiding this comment.
self.remote_services.values() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
RemoteDrivercan be added toTest's driver dependency graph.Solution description
update type checking, can it be tested in gh ci?
Checklist: