Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/update interactive & assertions doc #1127

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

zhenyu-ms
Copy link
Contributor

Bug / Requirement Description

Clearly and concisely describe the problem.

Solution description

Describe your code changes in detail for reviewers.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@zhenyu-ms zhenyu-ms requested a review from a team as a code owner August 23, 2024 10:31
yuxuan-ms
yuxuan-ms previously approved these changes Aug 23, 2024
@@ -73,6 +73,12 @@ circumstances.
* In interactive mode, all modules containing test targets will be loaded at
the same time, if the modules from which tasks are scheduled have the same
name, they won't be reloaded properly.
* `modulefinder.ModuleFinder <https://docs.python.org/3/library/modulefinder.html#modulefinder.ModuleFinder>`_
works purely on static analysis, which means it is completely ignorant of any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's explain in a bit more detail how module finder find the dependency of the module from import statement:

  • absolute import if the module path is accessible from the root (pwd)? (e.g import a.b.c, and if a is under root syspath)
  • relative import if the module path is reachable from current module (e.g import ..x.y, if we can traverse to x from current module)

run this through co-pilot for refinement

@zhenyu-ms zhenyu-ms changed the title Doc/update interactive reload limitation Doc/update interactive & assertions doc Sep 3, 2024
@zhenyu-ms zhenyu-ms merged commit 61e8a60 into morganstanley:main Sep 3, 2024
8 checks passed
@zhenyu-ms zhenyu-ms deleted the doc branch September 3, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants