Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add early stop in pool. #1122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add early stop in pool. #1122

wants to merge 1 commit into from

Conversation

yuxuan-ms
Copy link
Contributor

Bug / Requirement Description

Clearly and concisely describe the problem.

Solution description

Describe your code changes in detail for reviewers.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@yuxuan-ms yuxuan-ms requested a review from a team as a code owner August 5, 2024 05:55
@yuxuan-ms yuxuan-ms marked this pull request as draft August 5, 2024 05:56
@yuxuan-ms yuxuan-ms force-pushed the early_stop branch 2 times, most recently from 21cba05 to f892ce1 Compare August 12, 2024 03:38
@yuxuan-ms yuxuan-ms marked this pull request as ready for review August 20, 2024 05:51
Pyifan
Pyifan requested changes Aug 27, 2024
View reviewed changes
testplan/runners/pools/remote.py Outdated Show resolved Hide resolved
Pyifan
Pyifan requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@Pyifan Pyifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add announcement and test.

testplan/runners/pools/remote.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pyifan Pyifan Pyifan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuxuan-ms @Pyifan