Fix interactive mode render issue.

morganstanley · Aug 22, 2023 · af986e0 · af986e0
1 parent 331ace2
commit af986e0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/doc/newsfragments/2590_changed.interactive_render_issue.rst b/doc/newsfragments/2590_changed.interactive_render_issue.rst
@@ -0,0 +1 @@
+Fix interactive mode table rendered with every poll (Bad UX scroll/highlight not maintained)
diff --git a/testplan/common/utils/comparison.py b/testplan/common/utils/comparison.py
@@ -329,8 +329,11 @@ def serialize(cls, obj):
 
     @classmethod
     def match(cls, regex, value):
-
-        return Match.from_bool(bool(regex.match(value)))
+        try:
+            ret = bool(regex.match(value))
+        except TypeError:
+            ret = False
+        return Match.from_bool(ret)
 
     @staticmethod
     def compare(lhs, rhs):

diff --git a/testplan/web_ui/testing/src/Report/InteractiveReport.js b/testplan/web_ui/testing/src/Report/InteractiveReport.js
@@ -122,7 +122,9 @@ class InteractiveReportComponent extends BaseReport {
             response.data.runtime_status === "finished" ||
             response.data.runtime_status === "not_run"
           ) {
-            this.setState({ resetting: false });
+            if (this.state.resetting){
+              this.setState({ resetting: false });
+            }
           }
           if (
             !this.state.report ||