Feature/raise intent for context #809
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilla28
reviewed
Nov 5, 2024
| /// </summary> | ||
| public static bool DoesListenForIntent(this Fdc3App app, string intentName) | ||
| { | ||
| if (app?.Interop?.Intents?.ListensFor == null) { return false; } |
There was a problem hiding this comment.
nitpick: can you please do the brackets in other lines
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| private async Task<IntentQueryResult> GetAppIntentsFromAppDirectory( | ||
| Func<Fdc3App, Dictionary<string, AppIntent>, IEnumerable<KeyValuePair<string, IntentMetadata>>?> selector, | ||
| private async Task<IntentQueryResult> GetAppIntentsFromRunningModules( |
There was a problem hiding this comment.
This method is not used anywhere. Do we need it?
| @@ -24,13 +25,13 @@ public interface IResolverUICommunicator | |||
| /// </summary> | |||
| /// <param name="intents"></param> | |||
| /// <returns></returns> | |||
| public Task<ResolverUIIntentResponse?> SendResolverUIIntentRequest(IEnumerable<string> intents, CancellationToken cancellationToken = default); | |||
| public Task<ResolverUIIntentResponse?> SendResolverUIIntentRequest(IEnumerable<string> intents, TimeSpan? timeout = null); | |||
|
|
|||
| /// <summary> | |||
| /// Sends a request for the shell to show a window, aka ResolverUI, with the appropriate AppMetadata that can solve the raised intent. | |||
| /// </summary> | |||
| /// <param name="appMetadata"></param> | |||
| /// <param name="cancellationToken"></param> | |||
There was a problem hiding this comment.
please fix the xml comments as well
|
|
||
| namespace MorganStanley.ComposeUI.Fdc3.DesktopAgent.Infrastructure.Internal; | ||
|
|
||
| internal class IntentResolver |
psmulovics
reviewed
Nov 6, 2024
| /// </summary> | ||
| public static bool DoesAcceptContextType(this Fdc3App app, string contextType) | ||
| { | ||
| if (app?.Interop?.Intents?.ListensFor == null) { return false; } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.