Fixes for bugs encoutered when proof-reading Romain's blog post #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ClotildeToullec
commented
Oct 10, 2024
ClotildeToullec
commented
- Remove reference to FamixTParameterizedType
- Deal with invocations that do not have a source anchor. Please review this before merging, I am not sure this fix is right.
Parametric classes inherit from class now.
+ Deal with empty source anchors. Not sure the default 0 value is correct.
Pull Request Test Coverage Report for Build 11278299554Details
💛 - Coveralls |
badetitou
requested changes
Oct 24, 2024
| CRFBinderVisitor >> determineAttributeWithName: aVariableName fromFamixEntity: aFamixEntity [ | ||
|
|
||
| ((((aFamixEntity allAtAnyScope: { | ||
| FamixTParameterizedType. |
There was a problem hiding this comment.
Why removing FamixTPArameterizedType? Maybe it has been rename?
It is strange that no tests fails for that... I suggest to first try to have a look at this
|
After re looking at this issue. It is more a problem of version between Moose11 and Moose12. Ok to start a v6 with Moose 12 support |
|
Oo. I tested and it also works with Moose 11... I'm completely puzzled... tests are the most important stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.