Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: move sys to core #89

Merged
merged 2 commits into from
Jan 13, 2025
Merged

internal: move sys to core #89

merged 2 commits into from
Jan 13, 2025

Conversation

Young-Flash
Copy link
Collaborator

Copy link

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are three observations from the provided git diff output:

  1. Version Bump in moon.mod.json:

    • The version in moon.mod.json has been updated from 0.4.16 to 0.4.17. This is a common practice when releasing new features or bug fixes. However, ensure that this version bump is intentional and aligns with the project's versioning strategy.
  2. Deletion of ffi and Related Files:

    • Several files related to the Foreign Function Interface (FFI) have been deleted, including ffi.mbti, moon.pkg.json, sys_js.mbt, sys_native.mbt, and sys_wasm.mbt. This suggests a significant refactoring or removal of FFI functionality. Ensure that this deletion is intentional and that no dependent code relies on these files.
  3. Deletion of sys Package Files:

    • The entire sys package, including moon.pkg.json, sys.mbt, sys.mbti, and sys_test.mbt, has been deleted. This indicates a major change in the project structure or functionality. Verify that this deletion is intended and that no other parts of the project depend on the sys package.

These changes suggest a significant refactoring or removal of functionality. Ensure that these changes are intentional and that they do not break any dependencies or expected behavior in the project.

@Young-Flash Young-Flash merged commit 28c7480 into main Jan 13, 2025
12 checks passed
@Young-Flash Young-Flash deleted the move_sys_to_core branch January 13, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant