Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in Chapter 2 #26

Merged
merged 7 commits into from
Jun 3, 2024
Merged

fix: typo in Chapter 2 #26

merged 7 commits into from
Jun 3, 2024

Conversation

phaleth
Copy link
Contributor

@phaleth phaleth commented Jun 2, 2024

No description provided.

@skylee03 skylee03 self-requested a review June 2, 2024 14:49
@skylee03 skylee03 self-assigned this Jun 2, 2024
@skylee03 skylee03 added the good first issue Good for newcomers label Jun 2, 2024
@skylee03
Copy link
Collaborator

skylee03 commented Jun 2, 2024

LGTM! I will fix them as soon as possible. If you have any other feedback, please let us know!

@skylee03
Copy link
Collaborator

skylee03 commented Jun 2, 2024

I noticed that you opened a PR for each typo, so I'll merge them to avoid cluttering the git log.

@skylee03 skylee03 mentioned this pull request Jun 2, 2024
@phaleth
Copy link
Contributor Author

phaleth commented Jun 2, 2024

yeah, I keep opening new PRs, cause I'm not sure you gonna apply each and every of those changes

feel free to close the other ones

@skylee03 skylee03 mentioned this pull request Jun 2, 2024
@skylee03
Copy link
Collaborator

skylee03 commented Jun 2, 2024

yeah, I keep opening new PRs, cause I'm not sure you gonna apply each and every of those changes

feel free to close the other ones

Let me know when you're done. Thanks!

Copy link
Collaborator

@skylee03 skylee03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution.
I will merge these changes now. If you have other changes later, please feel free to open a new PR.

@skylee03 skylee03 merged commit 75bc751 into moonbitlang:main Jun 3, 2024
2 checks passed
@phaleth phaleth deleted the patch-1 branch June 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants