Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Chapter 7 #25

Merged
merged 5 commits into from
Jun 17, 2024
Merged

feat: add Chapter 7 #25

merged 5 commits into from
Jun 17, 2024

Conversation

skylee03
Copy link
Collaborator

No description provided.

@skylee03 skylee03 self-assigned this May 27, 2024
@skylee03 skylee03 marked this pull request as ready for review May 27, 2024 09:52
@skylee03 skylee03 changed the title add Chapter 7 feat: add Chapter 7 Jun 4, 2024
![debugger](/pics/debugger.webp)

## Loops

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we introduced for-else loop and functional loop yet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used functional loop in Chapter 4, but we haven't introduced them yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I need to update the example to avoid introducing the loops too early.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we should remove the usage of functional loop there. I also notice that we need to introduce function matrix in Chapter 5 just after pattern matching.

@peter-jerry-ye
Copy link
Contributor

Also check with the original script to see if anything is missing

@skylee03
Copy link
Collaborator Author

skylee03 commented Jun 6, 2024

I have added some content that was in the Chinese lecture scripts but is missing in the current English version, but have not introduced any new content yet.

@skylee03 skylee03 merged commit d6a0f19 into moonbitlang:main Jun 17, 2024
3 checks passed
@skylee03 skylee03 deleted the chapter7 branch June 17, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants