Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: disable moon query test #559

Merged
merged 1 commit into from
Jan 10, 2025
Merged

minor: disable moon query test #559

merged 1 commit into from
Jan 10, 2025

Conversation

Young-Flash
Copy link
Collaborator

No description provided.

Copy link

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are some observations and potential issues from the provided git diff output:

  1. Incorrect Comment for #[ignore]:

    • The comment #[ignore = "moon query may no support anymore"] contains a typo. It should likely be "moon query may not be supported anymore" or "moon query may no longer be supported". The current phrasing is unclear and grammatically incorrect.
  2. Potential Deprecation:

    • The addition of the #[ignore] attribute suggests that the test_moon_query function is no longer relevant or supported. If this is the case, consider removing the test entirely or updating it to reflect the current state of the codebase. Ignoring tests without a clear reason can lead to technical debt.
  3. Unused or Redundant Code:

    • The test_moon_query function appears to be setting up a TestDir but does not include any assertions or test logic. If this test is no longer supported, ensure that any associated setup or cleanup code is also removed to avoid confusion or unnecessary maintenance.

Let me know if you'd like further clarification or assistance!

@Young-Flash Young-Flash enabled auto-merge (squash) January 10, 2025 08:10
@Young-Flash Young-Flash merged commit 8a8308c into main Jan 10, 2025
14 checks passed
@Young-Flash Young-Flash deleted the promote_test branch January 10, 2025 08:17
@Young-Flash Young-Flash restored the promote_test branch January 10, 2025 08:17
@Young-Flash Young-Flash deleted the promote_test branch January 10, 2025 08:18
Lampese added a commit to Lampese/moon-oj-special that referenced this pull request Jan 10, 2025
* minor: disable moon query test (moonbitlang#559)

* feat: wasm memory and time limit

---------

Co-authored-by: Young-Flash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant