add: byte view traits & binary representation methods. #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a direct port of practice-tested
loneoutpost/core-extra/representation
mooncake.contents
This PR includes 2 main additions:
trait ByteView
&trait ByteMutView
to indicate byte-slice-like objects, and typestruct BytesView
which is a concrete slice type matches above traits.Int
,Int64
andDouble
supporting user specified endianness.Solid and complete tests and documentations provided.
notes
This PR somewhats implements #341.
This PR may be competing to #328 #329. In my opinion,
ByteView
(can only get Byte) andByteMutView
(can get and set) trait abstractions are critical, butLoadable
orStorable
abstractions is not needed incore
. Referencing the practices from Rust, these abstractions is more appropriate to appear asSerializable
/Deserializable
in aserde
3rd party mooncake.