Allow assets managed by AssetManager and EvmForeignAssets to use the pallet-xcm precompile #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AssetManager as asset managers
WASM runtime size check:Compared to target branchMoonbase runtime: 2284 KB (no changes) ✅ Moonbeam runtime: 2264 KB (no changes) ✅ Moonriver runtime: 2252 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2284 KB (+256 KB compared to latest release) Moonbeam runtime: 2264 KB (+252 KB compared to latest release) Moonriver runtime: 2252 KB (+240 KB compared to latest release) |
RomarQ
added
the
B7-runtimenoteworthy
RomarQ
changed the title
EvmForeignAssets and AssetManager as asset managers
RomarQ
added
not-breaking
Coverage Report@@ Coverage Diff @@
## master rq/update-AssetIdToLocationManager +/- ##
=====================================================================
Coverage 74.47% 74.47% 0.00%
Files 377 377
Lines 95720 95720
=====================================================================
Hits 71283 71283
Misses 24437 24437
|
manuelmauro
previously approved these changes
Jan 17, 2025
TarekkMA
previously approved these changes
Jan 17, 2025
Yes, exactly. |
Added a test with the old approach, the assets manager pallet is going to be removed in future upgrades. |
TarekkMA
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Followup of #3107
This change allows assets managed by
AssetManagerandEvmForeignAssetsto use the pallet-xcm precompile.