Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoke): Fix foreign assets smoke tests #3108

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Dec 17, 2024

What does it do?

With the new native ERC20 foreign assets, the smoke test needs to fetch assets from 2 different pallets.

@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes I4-tests 🎯 Tests need fixing, improving or augmenting. D2-notlive PR doesn't change runtime code (so can't be audited) labels Dec 17, 2024
@RomarQ RomarQ self-assigned this Dec 17, 2024
Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2248 KB (no changes) ✅

Moonriver runtime: 2240 KB (no changes) ✅

Compared to latest release (runtime-3400)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2248 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2240 KB (+228 KB compared to latest release) ⚠️

Copy link
Contributor

Coverage Report

@@                      Coverage Diff                       @@
##           master   rq/fix-foreign-assets-smoke     +/-   ##
==============================================================
  Coverage   74.58%                        74.58%   0.00%     
  Files         375                           375             
  Lines       95681                         95681             
==============================================================
  Hits        71358                         71358             
  Misses      24323                         24323             
Files Changed Coverage

Coverage generated Tue Dec 17 09:47:33 UTC 2024

@RomarQ RomarQ requested a review from ahmadkaouk December 17, 2024 09:58
@RomarQ RomarQ merged commit 40f1fde into master Dec 17, 2024
47 checks passed
@RomarQ RomarQ deleted the rq/fix-foreign-assets-smoke branch December 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) evm-native-foreign-assets I4-tests 🎯 Tests need fixing, improving or augmenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants