Update smoke tests for the EVM native assets #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noandrea
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2196 KB (no changes) ✅ Moonbeam runtime: 2140 KB (no changes) ✅ Moonriver runtime: 2132 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2196 KB (+236 KB compared to latest release) Moonbeam runtime: 2140 KB (+216 KB compared to latest release) Moonriver runtime: 2132 KB (+208 KB compared to latest release) |
librelois
previously approved these changes
Sep 17, 2024
Coverage Report@@ Coverage Diff @@
## master noandrea-smoke-s12-fix +/- ##
=========================================================
Coverage 79.34% 79.34% 0.00%
Files 298 298
Lines 87113 87113
=========================================================
Hits 69114 69114
Misses 17999 17999
|
Replaced the old test with a new one using xcmWeightTrader supported assets. Should be good to go now. |
pLabarta
approved these changes
Sep 18, 2024
RomarQ
reviewed
Sep 18, 2024
librelois
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix the S12 smoke tests for foreign assets, by removing querying the access to the storage that has been removed in the native EVM foreign assets.
see: https://github.com/moonbeam-foundation/moonbeam/pull/2952/files#diff-59e32ab98930c781214cbb00f1682072999dd322f1220a8c34e80f3a07488d0c
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?