Moves precompile-utils into frontier (#2181) #2427
Conversation
rimbi
added
A0-pleasereview
rimbi
changed the title
| @@ -733,45 +733,42 @@ fn read_complex_solidity_function() { | |||
| #[test] | |||
| fn junctions_decoder_works() { | |||
| let writer_output = Writer::new() | |||
| .write(Junctions::X1(Junction::OnlyChild)) | |||
| .write(XCMJunctions(Junctions::X1(Junction::OnlyChild))) | |||
There was a problem hiding this comment.
Small grumble: Following Rust naming conventions it should be XcmJunctions.
Cargo.lock
Outdated
| @@ -2971,7 +2941,7 @@ dependencies = [ | |||
| "fc-rpc-core", | |||
| "fc-storage", | |||
| "fp-ethereum", | |||
| "fp-evm", | |||
| "fp-evm 3.0.0-dev (git+https://github.com/moonbeam-foundation/frontier?branch=moonbeam-polkadot-v0.9.43)", | |||
There was a problem hiding this comment.
Theses kind of lines reveals that you have a problem of git dependencies duplication, please fix it
|
@rimbi Can you please fix the conflicts with master? this is needed for the CI to run. |
librelois
added
the
D5-nicetohaveaudit⚠️
|
Coverage generated "Fri Aug 11 13:34:36 UTC 2023": Master coverage: 87.39% |
|
@rimbi If this is ready for review, please move it from draft to PR |
| @@ -876,7 +876,7 @@ fn transfer_multi_assets_is_not_sorted_error() { | |||
| PCall::transfer_multi_assets { | |||
| assets: assets.into(), | |||
| fee_item: 0, | |||
| destination: destination.clone(), | |||
| destination: destination.clone().into(), | |||
There was a problem hiding this comment.
There are a lot of changes like this (adding a .into() call), do you know why?
There was a problem hiding this comment.
The reason is that I had to use new type pattern for the types like MultiLocation here.
There was a problem hiding this comment.
Oh, is this because Codec is no longer defined in the same crate? Hmmm...
@crystalin It will be ready for review only after:
This PR and the corresponding one in our frontier repo was used to show that the changes work. |
|
Pleease move the PR to "ready for review" and merge master into it, thank you |
What does it do?
Moves precompile-utils from moonbeam into frontier.
precompile-utilsprecompile-utils-macroprecompile-utils-tests-externalprecompile-utilsinto a separate crate calledprecompile-utils-xcm-codecand leaves it in moonbeam.Here is the complementary PR: moonbeam-foundation/frontier#177
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?