Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relocate substrate page from Builders to learn #1073

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

relocate substrate page from Builders to learn #1073

wants to merge 9 commits into from

Conversation

themacexpert
Copy link
Contributor

@themacexpert themacexpert commented Jan 13, 2025 •
edited
Loading

Description

relocates an abandoned substrate page from Builders to Learn section. It was abandoned in the sense that no navigation items led to it.

Checklist

  • I have added a label to this PR 🏷️

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert requested a review from eshaben January 13, 2025 23:37
@themacexpert themacexpert added A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) B0 - Needs Review Pull request is ready for review labels Jan 13, 2025
eshaben
eshaben reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look too closely at this, but there's some Substrate content in the Technology & Architecture, do you think it makes more sense to have this as a separate page or maybe combine it with that page?

@themacexpert themacexpert added A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) and removed A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) labels Jan 14, 2025
@themacexpert
Copy link
Contributor Author

I didn't look too closely at this, but there's some Substrate content in the Technology & Architecture, do you think it makes more sense to have this as a separate page or maybe combine it with that page?

Good idea! I've merged into one page

@themacexpert themacexpert requested a review from eshaben January 14, 2025 18:52
eshaben
eshaben reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for formatting. Would love for @ibbar to review this!

learn/platform/technology.md Outdated Show resolved Hide resolved
learn/platform/technology.md Outdated Show resolved Hide resolved
learn/platform/technology.md Outdated Show resolved Hide resolved
learn/platform/technology.md Outdated Show resolved Hide resolved
@eshaben eshaben requested a review from ibbar January 17, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibbar ibbar Awaiting requested review from ibbar

@eshaben eshaben Awaiting requested review from eshaben

@dawnkelly09 dawnkelly09 Awaiting requested review from dawnkelly09

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) B0 - Needs Review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themacexpert @eshaben