Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gitpod support #277

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add Gitpod support #277

merged 1 commit into from
Nov 28, 2023

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Nov 27, 2023

During my project week, I've been working on this feature to implement a mechanism for easily deploying and testing Moodle tracker issues.
Gitpod is a free, cloud-based, development environment providing a suitable development environment right in your browser.

The Moodle Gitpod template supports the following environment variables:

  • MOODLE_REPOSITORY. The Moodle repository to be cloned. The value should be URL encoded. If left undefined, the default repository https://github.com/moodle/moodle.git is used.
  • MOODLE_BRANCH. The Moodle branch to be cloned. If left undefined, the default branch main is employed.

In case it helps, for adding the gitpod.yml I followed the official documentation: https://www.gitpod.io/docs/references/gitpod-yml

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sara, I've added 3-4 non-critical comments or suggestions in the review.

I've been perfectly able to create a few workspaces, both the "default" one and a custom repo/branch one, browse the site once installed perfectly and, also, edit the code remotely with PHPStorm (I've not tried other integrations).

So far, everything has worked perfectly. So I think this is 99% ready.

Awesome integration, ciao :-)

.gitpod.yml Show resolved Hide resolved
.gitpod.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Gitpod is a free, cloud-based, development environment providing a
suitable development environment right in your browser.

The Moodle Gitpod template supports the following environment variables:

* `MOODLE_REPOSITORY`. The Moodle repository to be cloned. The value
should be URL encoded. If left undefined, the default repository
`https://github.com/moodle/moodle.git` is used.

* `MOODLE_BRANCH`. The Moodle branch to be cloned. If left undefined,
the default branch `main` is employed.
@sarjona
Copy link
Member Author

sarjona commented Nov 28, 2023

Hola @stronk7!
Thanks a lot for reviewing this patch and raising these improvements! I've done most of the changes (and confirmed they haven't broken anything).
It's great you tested it using the PHPStorm bridge because, while working on it, I only tested it using VSCode (web and also local). I love to see the integration with PHPStorm is also working fine <3

Over to you! :-)

@stronk7
Copy link
Member

stronk7 commented Nov 28, 2023

All discussions resolved, changes look perfect... here we go!!!!

@stronk7 stronk7 merged commit df388f4 into moodlehq:master Nov 28, 2023
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants