Integrate uglify in web server image creation #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes have only been tested up to but not including the use of packer. Run locally, they successfully produced an uglified filament.tgz.
Vagrantfile
Outdated
| @@ -16,7 +16,7 @@ Vagrant.configure('2') do |config| | |||
|
|
|||
| # Disable Guest Addition install for the moment. It seems to cause more | |||
| # problems than it solves | |||
There was a problem hiding this comment.
This solved more problems than it caused for me.
There was a problem hiding this comment.
It's fixed things for Fabrice as well, so +1
|
Can one of the admins verify this patch? (Reply "ok to test") |
|
@declarativ-bot ok to test |
|
@Stuk, can you please take a look at this? Wouldn't mind seeing it merged assuming it's working just to get the "mopping" task off our plate. |
|
sure |
|
@kriskowal After uncompressing the contents of the tgz are: this is what the current tgz contains: obviously the mopped one is missing a lot of stuff. |
add travis build config
log uncaughtException on project, login and container
fix Object.map usage from old collections on containerIndex
update container and base image nodejs version from 0.10.x to 4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have only been tested up to but not including the use of
packer. Run locally, they successfully produced an uglified
filament.tgz.