refactor: use vendor css from npm package (@fehmer) #6206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeytypegeorge
added
frontend
fehmer
changed the title
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
fehmer
force-pushed
the
feature/remove-slimselect-css
branch
from
9fff86d to
81b7c56
Compare
fehmer
force-pushed
the
feature/remove-slimselect-css
branch
from
81b7c56 to
3e920c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the remaining "vendor" css files copied into
static/cssand pick them from npm packages instead.For the slimselect the css should match the version of the js. Since we use the slimselect
jsfile from the npm package we should use thecssfile from the package as well.For the balloon.css the file was copied into the project. Adding it as a dependency makes sure we know the version of it and we don't modify it in the project leading to problems when we try to update it later.
Similar to the vendor
jsfiles (js dependencies from packages) extract the vendorcssfiles into a separatecssfile as well.