Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profile): Streak hover text description without a streak offset is now consistent with the setting's location (@wclxb) #6190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wclxb
Copy link

@wclxb wclxb commented Jan 17, 2025

Make streak hover text when no streak offset is applied consistent with the setting location

Description

The hover text label now properly directs a user to the "Account Settings > Account" section instead of "Settings > Danger Settings" when they don't have a streak offset set.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Make streak hover text when no streak offset is applied consistent with the setting location
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants