fix: remove scale effect on theme button hover (@fehmer) #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
force-pushed
the
feature/fix-customthemebtn-hover
branch
from
027f48a to
7c00e53
Compare
Miodec
force-pushed
the
feature/fix-customthemebtn-hover
branch
from
7c00e53 to
5063687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale effect on hover on theme buttons can cause the button controls to be outside the visible area (reported on discord).
We don't use this effect everywhere else as far as I know. We could either remove the hover effect alltogether or replace it with the same effect (outline) we use to mark the active selection.