Upgrade to mongoid 9 #105
Merged
Upgrade to mongoid 9 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of running |
dblock
requested changes
May 5, 2024
There was a problem hiding this comment.
Glad it works out of the box! Add to CI, https://github.com/mongoid/mongoid-locker/blob/master/.github/workflows/test.yml#L28, and CHANGELOG please?
Generated by 🚫 Danger |
|
@dblock Thanks for the review. Should we release this as a MAJOR or can we keep the next version as v2.0.3? |
fix rubocop fix readme update changelog: ' update change log, capture release version as 2.0.3 remove line in changelog
sairamsrinivasan
force-pushed
the
upgrade-mongoid-9
branch
from
9184793 to
73837ad
Compare
dblock
requested changes
May 6, 2024
CHANGELOG.md
Outdated
| * [#102](https://github.com/mongoid/mongoid-locker/pull/102): Re-added danger, removed Travis-CI config, extracted RuboCop - [@dblock](https://github.com/dblock). | ||
| * [#104](https://github.com/mongoid/mongoid-locker/pull/104): Fixed code coverage - [@dblock](https://github.com/dblock). | ||
| * [#101](https://github.com/mongoid/mongoid-locker/pull/101): Replace the $where operator with the $expr operator - [@amanfrinati](https://github.com/amanfrinati). | ||
| * Your contribution here. | ||
| * [#105](https://github.com/mongoid/mongoid-locker/pull/105): Upgraded supported mongoid version to version 9.0 - [@saisrinivasan](https://github.com/SairamSrinivasan) |
There was a problem hiding this comment.
Change to "Added support for Mongoid 9.0". Don't forget the period at the end or danger will complain.
|
Looks good, thank you. Will cut a release soon-ish unless someone beats me to it. Btw, lots of other mongoid- gems in this org could use similar help! |
|
I released 2.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to upgrade monogid to v9 as it was just released: https://www.mongodb.com/docs/mongoid/master/release-notes/mongoid-9.0/