allow modifier field to be optional

[yads]

No description provided.

[yads]

fix for #186

[dblock]

Looks good, needs specs, changelog, docs.

[coveralls]

Changes Unknown when pulling 50f4bfb on yads:master into ** on mongoid:master**.

[yads]

@dblock it looks like the optional association option is only available in Mongoid 6. Which this feature needs to work properly on Mongoid 6. Are you aware of how to do feature/version detection on which version of Mongoid this would be running against? I supposed I could also do something like:

begin
        belongs_to :modifier, class_name: Mongoid::History.modifier_class_name, optional: true
rescue
        belongs_to :modifier, class_name: Mongoid::History.modifier_class_name
end

Do you have any thoughts on how to handle this situation so that this feature works on mongoid versions < 6 and >= 6?

[dblock]

You can use checks in Mongoid::Compatibility to see what version is being used in both the implementation and the specs, so no rescue please.

[coveralls]

Changes Unknown when pulling 13063fa on yads:master into ** on mongoid:master**.

[yads]

@dblock added some specs and using mongoid-compatibility for feature detection. The only thing I had to up the rubocop module size as tracker.rb was right on the cusp of exceeding 176.

[dblock]

Getting close! Hang in there. There're no tests for the new modifier_field_optional option, please add.

[dblock]

This needs to become a .gemspec dependency, otherwise it will be failing at runtime.

[yads]

I believe it's already in the .gemspec file. Is this not it? https://github.com/mongoid/mongoid-history/blob/master/mongoid-history.gemspec#L23

[yads]

Or are you saying to add a version dependency so that it works with version 0.5.1 or above?

[dblock]

Then you don't need to add it here, don't you?

[coveralls]

Coverage decreased (-8.8%) to 90.996% when pulling 1b3c42d on yads:master into d6102a1 on mongoid:master.

[coveralls]

Coverage increased (+0.002%) to 99.762% when pulling 103dcb3 on yads:master into d6102a1 on mongoid:master.

[coveralls]

Coverage increased (+0.002%) to 99.762% when pulling 103dcb3 on yads:master into d6102a1 on mongoid:master.

[coveralls]

Coverage increased (+0.002%) to 99.763% when pulling 01fd3c8 on yads:master into d6102a1 on mongoid:master.

[coveralls]

Coverage increased (+0.002%) to 99.763% when pulling 01fd3c8 on yads:master into d6102a1 on mongoid:master.

[coveralls]

Coverage increased (+0.002%) to 99.763% when pulling 01fd3c8 on yads:master into d6102a1 on mongoid:master.

[coveralls]

Coverage increased (+0.002%) to 99.763% when pulling 01fd3c8 on yads:master into d6102a1 on mongoid:master.

[yads]

Yay, finally passing!

[dblock]

Fyi usually we just run rubocop -a ; rubocop --auto-gen-config.

[yads]

Ah ok, I was wondering why 176 was the old value :)

[dblock]

Merging this, thanks!

[dblock]

Coming from #221.

Is the modifier still not actually enforced in Mongoid 6? A spec like https://github.com/mongoid/mongoid-history/blob/master/spec/unit/attributes/destroy_spec.rb never uses a modifier but succeeds in 6 and now fails in 7 saying a modifier is required.