Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back fetching modifier from controller #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

melnikaite
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.151% when pulling 8556240 on melnikaite:set_modifier_id into 6948018 on aq1018:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.151% when pulling 003d259 on melnikaite:set_modifier_id into 6948018 on aq1018:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.06% when pulling d295a99 on melnikaite:set_modifier_id into 6948018 on aq1018:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.994% when pulling 628bc67 on melnikaite:set_modifier_id into 6948018 on aq1018:master.

@melnikaite melnikaite force-pushed the set_modifier_id branch 2 times, most recently from beb94ad to d112219 Compare March 29, 2016 11:05
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.06% when pulling beb94ad on melnikaite:set_modifier_id into 6948018 on aq1018:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.152% when pulling d112219 on melnikaite:set_modifier_id into 6948018 on aq1018:master.

@dblock
Copy link
Collaborator

dblock commented Mar 29, 2016

I think this is ok to merge, but I've never heard of Tenacity and maybe we should call that out separately, with documentation and tests?

@dblock
Copy link
Collaborator

dblock commented Mar 29, 2016

Other thoughts: maybe Hooks should be a more explicit class name, like Hooks::UpdatedBy or Hooks::Modifier?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.994% when pulling ea2019e on melnikaite:set_modifier_id into 6948018 on aq1018:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.994% when pulling 73bd9eb on melnikaite:set_modifier_id into 6948018 on aq1018:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants