-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back fetching modifier from controller #149
Open
melnikaite
wants to merge
1
commit into
mongoid:master
Choose a base branch
from
melnikaite:set_modifier_id
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melnikaite
force-pushed
the
set_modifier_id
branch
from
March 28, 2016 16:28
8556240
to
003d259
Compare
melnikaite
force-pushed
the
set_modifier_id
branch
from
March 28, 2016 16:48
003d259
to
d295a99
Compare
melnikaite
force-pushed
the
set_modifier_id
branch
from
March 28, 2016 17:56
d295a99
to
628bc67
Compare
melnikaite
force-pushed
the
set_modifier_id
branch
2 times, most recently
from
March 29, 2016 11:05
beb94ad
to
d112219
Compare
I think this is ok to merge, but I've never heard of Tenacity and maybe we should call that out separately, with documentation and tests? |
Other thoughts: maybe Hooks should be a more explicit class name, like |
melnikaite
force-pushed
the
set_modifier_id
branch
from
March 29, 2016 11:18
d112219
to
ea2019e
Compare
melnikaite
force-pushed
the
set_modifier_id
branch
from
March 29, 2016 11:22
ea2019e
to
73bd9eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.