Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user interface for Bands, Tours and Shows #1

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Add user interface for Bands, Tours and Shows #1

wants to merge 20 commits into from

Conversation

tmaier
Copy link

@tmaier tmaier commented Nov 30, 2011

This is the first step for views and controllers for echo.

This pull requests

  • adds a few more gems to make development easier,
  • fixes some bugs regarding the view,
  • adds views and controller
    • Bands
    • Tours
    • Shows

I test most of the things with the request spec. I hope this is fine for you.
It's not about beauty. I just want to get the basics working to have a framework to test and prove bugs etc.

I'm happy to hear if this is fine for your and your comments and thoughts about this.

@durran
Copy link
Member

durran commented Dec 7, 2011

Awesome thanks! I'm actually going to pick parts of this to bring in though, as I was starting to do the front-end in backbone.js - but there a few things I know off the top I wasn't going to use:

  • inherited_resources (I think it's a bit too much magic, and the Rails pattern of copying instance variables from the controllers into the views is a bad practice. I'd be using decent_exposure instead in the controllers)
  • database_cleaner (I don't think there's a need for the gem when a simple Mongoid.purge! in the rspec config for before hooks takes care of it.)

I'll have a chance to go through this more in the next week since I am slammed with work right now... But awesome pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants