CLOUDP-238915: Move to operator-sdk v1.34.1 #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-urbaniak
approved these changes
Mar 25, 2024
helderjs
force-pushed
the
CLOUDP-238915-update-operator-sdk
branch
from
de6646d
to
98782b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).I'm anticipating this task once I'd like to have it to be able to ship some code with generics at #1466
As I have been using operator-sdk in the latest version for a while locally, I checked what was necessary to migrate/update it and it seems to be as simple as this PR shows. No changes in base manifests.
The next release, bundle will reflect the update of controller gen in the manifests and the new project layout,
go.kubebuilder.io/v4in the CSV:The warning triggered was because
PROJECTconfig had v1beta1 API set for backup CRDs (not sure why) but both CRDs were already in v1(along with all others) and didn't have changes in them.