CLOUDP-239117: Increased resources limits for AKO container #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-urbaniak
requested changes
Mar 25, 2024
config/manager/manager.yaml
Outdated
| @@ -45,8 +45,8 @@ spec: | |||
| imagePullPolicy: Always | |||
| resources: | |||
| limits: | |||
| cpu: 500m | |||
| memory: 256Mi | |||
| cpu: 1000m | |||
There was a problem hiding this comment.
we shouldn't set cpu limits.
There was a problem hiding this comment.
| cpu: 500m | ||
| memory: 256Mi | ||
| cpu: 1000m | ||
| memory: 1Gi |
There was a problem hiding this comment.
Is this value measured or just a guess? If it is the latter we should measure first, i.e. based off integration tests.
There was a problem hiding this comment.
Additionally, the limit should equal the request, see the above blog post as well.
|
generally: I'd recommend running integration tests locally, using kind with a deployed Prometheus setup and use https://github.com/robusta-dev/krr to measure. I can help here if needed. |
|
As per our conversation @s-urbaniak I updated the PR. |
s-urbaniak
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).