-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-239117: Increased resources limits for AKO container #1472
Conversation
config/manager/manager.yaml
Outdated
@@ -45,8 +45,8 @@ spec: | |||
imagePullPolicy: Always | |||
resources: | |||
limits: | |||
cpu: 500m | |||
memory: 256Mi | |||
cpu: 1000m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't set cpu limits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpu: 500m | ||
memory: 256Mi | ||
cpu: 1000m | ||
memory: 1Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this value measured or just a guess? If it is the latter we should measure first, i.e. based off integration tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, the limit should equal the request, see the above blog post as well.
generally: I'd recommend running integration tests locally, using kind with a deployed Prometheus setup and use https://github.com/robusta-dev/krr to measure. I can help here if needed. |
As per our conversation @s-urbaniak I updated the PR. |
All Submissions:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if there is one).