Do NOT use pull_request_target events #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just avoid contributions to run ANY tests at all by default. Instead, testing needs to be excplictly alloed by lebaling the PR after inspecting it looks sane. Signed-off-by: jose.vazquez <[email protected]>
roothorp
approved these changes
Mar 15, 2024
igor-karpukhin
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just avoid contributions to run ANY tests at all by default.
Instead, testing needs to be explicitly allowed by labelling the PR after inspecting it looks sane.
✅ Test on fork: Dummy change from another fork had to be labeled to run tests.
✅ Test on fork: Dependabot change runs tests after adding the
retestlabel, as usual.✅ Test on fork: Regular change runs tests by default.
All Submissions: