Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do NOT use pull_request_target events #1446

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Do NOT use pull_request_target events #1446

merged 1 commit into from
Mar 15, 2024

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Mar 14, 2024

Just avoid contributions to run ANY tests at all by default.

Instead, testing needs to be explicitly allowed by labelling the PR after inspecting it looks sane.


Test on fork: Dummy change from another fork had to be labeled to run tests.
Test on fork: Dependabot change runs tests after adding the retest label, as usual.
Test on fork: Regular change runs tests by default.

All Submissions:

  • Have you signed our CLA?

@josvazg josvazg requested a review from roothorp March 14, 2024 18:12
Just avoid contributions to run ANY tests at all by default.

Instead, testing needs to be excplictly alloed by lebaling the PR
after inspecting it looks sane.

Signed-off-by: jose.vazquez <[email protected]>
@josvazg josvazg merged commit 28a96a3 into main Mar 15, 2024
15 checks passed
@josvazg josvazg deleted the no-pr-target branch March 15, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants