Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-230403: Avoid error 'version' not provided #1388

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Feb 20, 2024

The version is calculated at the Print Env and Get version step. Such version takes the input version as a hint, or calculates it from the push event branch name.

In either case, the version to use after that step is always steps.tag.outputs.version, never github.event.inputs.version again.

All Submissions:

  • Have you signed our CLA?

@josvazg
Copy link
Collaborator Author

josvazg commented Feb 20, 2024

cc @helderjs @s-urbaniak @igor-karpukhin
Problem is, I do not see an easy way to test this before an actual release. This was breaking the push workflow, not the manually triggered one we use for testing usually.

@josvazg josvazg merged commit 990581a into main Feb 20, 2024
8 checks passed
@josvazg josvazg deleted the CLOUDP-230403/fix-release-wf branch February 20, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants