CLOUDP-229283: disable ownership detection

[s-urbaniak]

All Submissions:

• Have you signed our CLA?
• Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
• Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

[github-actions]

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/401f60e189faab3310364724c755744dae05e40d

[igor-karpukhin]

Great fix! 👍

[josvazg]

LGTM!

Be aware though, that this is missing the subobject checks. Those are not called IsOwner, but instead can...Reconcile, eg. canAuditingReconcile.

BTW, the IsOwner is used on top level objects that we are pretty sure will remove the check for good, with no replacement. Where as the can...Reconcile will need to be revisited with a proper alternative.

An useful regexp to find the affected code is can.*Reconcile which renders me 36 results in 12 files. I would vote to do that in a separate PR.

These are

[s-urbaniak]

@josvazg if there is something missing, we should definitely add it to this PR:

Be aware though, that this is missing the subobject checks. Those are not called isOwner, but instead can...Reconcile, eg. canUditingReconcile.

This definitely should be covered by setting SubObjectDeletionProtection: false at the reconciler struct level. Please advise what else we should do here.

[josvazg]

@josvazg if there is something missing, we should definitely add it to this PR:

Be aware though, that this is missing the subobject checks. Those are not called isOwner, but instead can...Reconcile, eg. canUditingReconcile.

This definitely should be covered by setting SubObjectDeletionProtection: false at the reconciler struct level. Please advise what else we should do here.

Yes, they are also disabled already, but maybe it would be good to mark the code as disabled explicitly?
We could skip and just go for a later removal. Not a big deal.

[josvazg]

We could skip and just go for a later removal. Not a big deal.

Lets do that and move on.