-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-224541: Added terminationProtection flag #1356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add e2e tests as a follow-up, preferably before we start the release tomorrow. If not, that's ok as well.
I added tests. PTAL @s-urbaniak @josvazg |
@igor-karpukhin instead of commenting I took the freedom to put a commit on top to untangle the nested ifs, PTAL |
fbd3d17
to
715aa6c
Compare
@@ -33,7 +33,7 @@ func init() { | |||
excludedClusterFieldsTheirs["replicationFactor"] = true | |||
|
|||
// Termination protection | |||
excludedClusterFieldsTheirs["terminationProtectionEnabled"] = true | |||
// excludedClusterFieldsTheirs["terminationProtectionEnabled"] = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these are leftovers from ToAtlas
methods tests. I can remove this in a separate PR
All Submissions:
Added terminationProtection flag
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if there is one).