CLOUDP-224541: Added terminationProtection flag #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-urbaniak
approved these changes
Feb 6, 2024
josvazg
approved these changes
Feb 6, 2024
|
I added tests. PTAL @s-urbaniak @josvazg |
|
@igor-karpukhin instead of commenting I took the freedom to put a commit on top to untangle the nested ifs, PTAL |
s-urbaniak
reviewed
Feb 8, 2024
s-urbaniak
reviewed
Feb 8, 2024
s-urbaniak
force-pushed
the
termination-protection-advanced-clusters
branch
from
fbd3d17
to
715aa6c
Compare
josvazg
reviewed
Feb 8, 2024
| @@ -33,7 +33,7 @@ func init() { | |||
| excludedClusterFieldsTheirs["replicationFactor"] = true | |||
|
|
|||
| // Termination protection | |||
| excludedClusterFieldsTheirs["terminationProtectionEnabled"] = true | |||
| // excludedClusterFieldsTheirs["terminationProtectionEnabled"] = true | |||
There was a problem hiding this comment.
Looks like these are leftovers from ToAtlas methods tests. I can remove this in a separate PR
josvazg
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Added terminationProtection flag
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).