Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-178753: Deletion protection for AtlasBackupSchedule and AtlasBackupPolicy #1116

Merged
merged 3 commits into from
Sep 9, 2023
Merged

CLOUDP-178753: Deletion protection for AtlasBackupSchedule and AtlasBackupPolicy #1116

merged 3 commits into from
Sep 9, 2023

Conversation

igor-karpukhin
Copy link
Collaborator

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@igor-karpukhin igor-karpukhin marked this pull request as ready for review September 6, 2023 14:50
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/13c31a81456954e855fbde654ae09465575c9cfd

@igor-karpukhin igor-karpukhin force-pushed the CLOUDP-178753/deletion-protection-backups branch from c41ecd4 to ba5706b Compare September 6, 2023 16:44
helderjs
helderjs requested changes Sep 7, 2023
View reviewed changes
pkg/api/v1/atlasbackupschedule_types.go Outdated Show resolved Hide resolved
pkg/api/v1/atlasbackupschedule_types_test.go Outdated Show resolved Hide resolved
pkg/controller/atlasdeployment/backup.go Outdated Show resolved Hide resolved
helderjs
helderjs approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@igor-karpukhin igor-karpukhin merged commit b9e7457 into main Sep 9, 2023
40 checks passed
@igor-karpukhin igor-karpukhin deleted the CLOUDP-178753/deletion-protection-backups branch September 9, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg left review comments

@helderjs helderjs helderjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-karpukhin @helderjs @josvazg