Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-193173: Add extra args to serverless tags updates #1115

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Aug 29, 2023

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@josvazg josvazg marked this pull request as draft August 29, 2023 16:10
@josvazg josvazg force-pushed the CLOUDP-193173/update-tags-args branch 2 times, most recently from b61881b to e3ab779 Compare August 30, 2023 06:47
@josvazg josvazg marked this pull request as ready for review August 30, 2023 06:47
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general 👍 See notes

config/crd/bases/atlas.mongodb.com_atlasdeployments.yaml Outdated Show resolved Hide resolved
pkg/controller/atlasdeployment/serverless_deployment.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@josvazg josvazg merged commit 338e39b into main Aug 31, 2023
40 checks passed
@josvazg josvazg deleted the CLOUDP-193173/update-tags-args branch August 31, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants