-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-170078: Add testing guide #1066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
approved these changes
Aug 4, 2023
josvazg
commented
Aug 4, 2023
josvazg
force-pushed
the
CLOUDP-170078/test-guide
branch
2 times, most recently
from
August 7, 2023 08:30
79295fa
to
526be6d
Compare
josvazg
force-pushed
the
CLOUDP-170078/test-guide
branch
from
August 7, 2023 08:34
526be6d
to
3ca0111
Compare
igor-karpukhin
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
josvazg
force-pushed
the
CLOUDP-170078/test-guide
branch
from
August 7, 2023 13:03
3ca0111
to
f079343
Compare
cveticm
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
3 tasks
Signed-off-by: Jose Vazquez <[email protected]>
josvazg
force-pushed
the
CLOUDP-170078/test-guide
branch
from
August 10, 2023 16:03
f079343
to
dcf5b71
Compare
helderjs
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if there is one).