Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner: continue on error for PE and peering connections #1054

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

igor-karpukhin
Copy link
Collaborator

All Submissions:

Cleaner: continue on error for PE and peering connections

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@igor-karpukhin igor-karpukhin marked this pull request as ready for review July 31, 2023 17:55
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

@igor-karpukhin igor-karpukhin removed the request for review from helderjs July 31, 2023 17:56
@@ -65,6 +65,7 @@ jobs:
run: (cd .github/actions/cleanup-pe && go run .)

- name: Run atlas project cleaner
if: always()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this here?

Copy link
Collaborator

@helderjs helderjs Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will execute this job even if the previous ones failed

@igor-karpukhin igor-karpukhin merged commit 007a9e7 into main Aug 1, 2023
33 of 38 checks passed
@igor-karpukhin igor-karpukhin deleted the fix/cleaner-continue-on-err branch August 1, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants