Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap hashi mutlierror for native go implementation #1042

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Swap hashi mutlierror for native go implementation #1042

merged 2 commits into from
Jul 20, 2023

Conversation

roothorp
Copy link
Collaborator

@roothorp roothorp commented Jul 19, 2023 •
edited
Loading

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@roothorp roothorp requested a review from helderjs July 19, 2023 15:03
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/39e14329b92d864df3b449e1e8ed25b716aa7fe8

igor-karpukhin
igor-karpukhin approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roothorp roothorp merged commit 698123b into main Jul 20, 2023
38 checks passed
@roothorp roothorp deleted the use-native-multierror branch July 20, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@helderjs helderjs Awaiting requested review from helderjs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roothorp @igor-karpukhin