Skip to content

Commit

Permalink
Fix version comparison at skip check
Browse files Browse the repository at this point in the history
Signed-off-by: jose.vazquez <[email protected]>
  • Loading branch information
josvazg committed Sep 10, 2024
1 parent 6f4e3a2 commit a32458a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/e2e/helm_chart_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ var _ = Describe("HELM charts", Ordered, func() {
releaseMajorVersion := strings.Split(releasedVersion, ".")[0]
if releaseMajorVersion != devMajorVersion {
skipped = true
Skip(fmt.Sprintf("cannot test upgrade from incompatible major release version %s to version %s",
Skip(fmt.Sprintf("cannot test upgrade from incompatible major release version %q to version %q",
releaseMajorVersion, devMajorVersion))
}
})
Expand Down
2 changes: 1 addition & 1 deletion test/helper/e2e/cli/helm/helm.go
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ func GetDevelopmentMayorVersion() (string, error) {
if err != nil {
return "", err
}
return string(majorVersion), nil
return strings.TrimSpace(string(majorVersion)), nil
}

func packageChart(sPath, dPath string) {
Expand Down

0 comments on commit a32458a

Please sign in to comment.