Check for appropriate DataFederation error codes

mongodb · Aug 7, 2023 · 567347f · 567347f
1 parent 15d3f05
commit 567347f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/controller/atlas/api_error.go b/pkg/controller/atlas/api_error.go
@@ -19,4 +19,7 @@ const (
 
 	// Resource not found
 	ResourceNotFound = "RESOURCE_NOT_FOUND"
+
+	// Instance for the passed {groupId, tenantName} pair does not exist
+	DataFederationTenantNotFound = "DATA_FEDERATION_TENANT_NOT_FOUND_FOR_NAME"
 )
diff --git a/pkg/controller/atlasdatafederation/datafederation_controller.go b/pkg/controller/atlasdatafederation/datafederation_controller.go
@@ -274,7 +274,7 @@ func managedByAtlas(ctx context.Context, atlasClient mongodbatlas.Client, projec
 		atlasDataFederation, _, err := atlasClient.DataFederation.Get(ctx, projectID, dataFederation.Spec.Name)
 		if err != nil {
 			var apiError *mongodbatlas.ErrorResponse
-			if errors.As(err, &apiError) && (apiError.ErrorCode == atlas.NotInGroup || apiError.ErrorCode == atlas.ResourceNotFound) {
+			if errors.As(err, &apiError) && (apiError.ErrorCode == atlas.DataFederationTenantNotFound || apiError.ErrorCode == atlas.ResourceNotFound) {
 				return false, nil
 			}
 			return false, err