CLOUDP-186825: Add deletion protection to deployments

Signed-off-by: Jose Vazquez <[email protected]>

pkg/controller/atlasdeployment/atlasdeployment_controller.go

@@ -225,19 +225,19 @@ func (r *AtlasDeploymentReconciler) checkDeploymentIsManaged(
 	project *mdbv1.AtlasProject,
 	deployment *mdbv1.AtlasDeployment,
 ) workflow.Result {
-	dply := deployment
+	advancedDeployment := deployment
 	if deployment.IsLegacyDeployment() {
-		dply = deployment.DeepCopy()
-		if err := ConvertLegacyDeployment(&dply.Spec); err != nil {
+		advancedDeployment = deployment.DeepCopy()
+		if err := ConvertLegacyDeployment(&advancedDeployment.Spec); err != nil {
 			result := workflow.Terminate(workflow.Internal, err.Error())
 			log.Errorw("failed to temporary convert legacy deployment", "error", err)
 			return result
 		}
-		dply.Spec.DeploymentSpec = nil
+		advancedDeployment.Spec.DeploymentSpec = nil
 	}
 
 	owner, err := customresource.IsOwner(
-		dply,
+		advancedDeployment,
 		r.ObjectDeletionProtection,
 		customresource.IsResourceManagedByOperator,
 		managedByAtlas(context, workflowCtx.Client, project.ID(), log),