Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: update documentation for golang #3338

Merged
merged 1 commit into from
Oct 23, 2024
Merged

task: update documentation for golang #3338

merged 1 commit into from
Oct 23, 2024

Commits on Oct 22, 2024

  1. task: update documentation for golang

    ## Description
    
    Updating documentation to cover golang version requirement
    
    ## Reason
    ```
     Building atlas binary
    go build -ldflags "-s -w -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.GitCommit=436cdc259407d225f622e5a407a43e43f4070d99 -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.Version=1.19.0-374-g436cdc259"  -o ./bin/atlas ./cmd/atlas
    go: go.mod requires go >= 1.23.1 (running go 1.21.3; GOTOOLCHAIN=local)
    make: *** [build] Error 1
    ```
    ## Separate concern
    
    Go.mod file does not use toolchain directive which can automatically request proper golang version to be used. 
    
    Since I moved from Atlas CLI I noticed we no longer use adsf tools definitions.
    wtrocki authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c5985d2 View commit details
    Browse the repository at this point in the history