Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: e2e clean up #3297

Merged
merged 1 commit into from
Oct 2, 2024
Merged

tests: e2e clean up #3297

merged 1 commit into from
Oct 2, 2024

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Oct 2, 2024

use more require.NoErrror over if err for some e2e tests

@gssbzn gssbzn requested a review from a team as a code owner October 2, 2024 13:51
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

| `federatedAuthentication federationSettings describe` | Y | Y
| Command | E2E Atlas | Atlas |
|:-----------------------------------------------------:|:---------:|:-----:|
| `alerts config create` | Y | Y |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to update this file as part of this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, intellij auto formatted the table to fix some missaligments

@gssbzn gssbzn merged commit 3e7feeb into master Oct 2, 2024
20 checks passed
@gssbzn gssbzn deleted the e2e-cleanup branch October 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants