Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-246693: Add ubuntu 2404 #2941

Merged
merged 6 commits into from
May 29, 2024
Merged

CLOUDP-246693: Add ubuntu 2404 #2941

merged 6 commits into from
May 29, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented May 8, 2024 •
edited
Loading

Proposed changes

CLOUDP-246693

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

fmenezes
fmenezes reviewed May 28, 2024
View reviewed changes
build/ci/repo_config.yaml
- name: ubuntu2404
type: deb
code_name: "noble"
edition: enterprise
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about org?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added~

@blva blva marked this pull request as ready for review May 28, 2024 16:54
@blva blva requested a review from a team May 28, 2024 16:54
@blva blva requested a review from fmenezes May 28, 2024 17:26
gssbzn
gssbzn approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit 301cd36 into master May 29, 2024
19 checks passed
@blva blva deleted the CLOUDP-246693 branch May 29, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@fmenezes fmenezes Awaiting requested review from fmenezes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blva @gssbzn @fmenezes