CLOUDP-211696 Skip serverless cleanup on gov #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
changed the title
fmenezes
commented
Nov 27, 2023
test/e2e/atlas/cleanup_test.go
Outdated
| @@ -85,6 +91,9 @@ func TestCleanup(t *testing.T) { | |||
| deleteAllDataFederations(t, cliPath, projectID) | |||
| }) | |||
| t.Run("delete all serverless instances", func(t *testing.T) { | |||
| if IsGov() { | |||
| t.Skip() | |||
gssbzn
reviewed
Nov 27, 2023
gssbzn
reviewed
Nov 27, 2023
test/e2e/atlas/cleanup_test.go
Outdated
| t.Parallel() | ||
| deleteOrgInvitations(t, cliPath) | ||
| }) | ||
| t.Run("trying to org teams", func(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| t.Run("trying to org teams", func(t *testing.T) { | |
| t.Run("trying to delete org teams", func(t *testing.T) { |
gssbzn
reviewed
Nov 27, 2023
test/e2e/atlas/cleanup_test.go
Outdated
| @@ -85,6 +91,9 @@ func TestCleanup(t *testing.T) { | |||
| deleteAllDataFederations(t, cliPath, projectID) | |||
| }) | |||
| t.Run("delete all serverless instances", func(t *testing.T) { | |||
| if IsGov() { | |||
| t.Skip() | |||
There was a problem hiding this comment.
Suggested change
| t.Skip() | |
| t.Skip("serverless is not available on gov") |
gssbzn
reviewed
Nov 27, 2023
| @@ -215,7 +215,7 @@ func deleteServerlessInstanceForProject(t *testing.T, cliPath, projectID, cluste | |||
| deleteCmd := exec.Command(cliPath, args...) | |||
| deleteCmd.Env = os.Environ() | |||
| resp, err := deleteCmd.CombinedOutput() | |||
| require.NoError(t, err, resp) | |||
| require.NoError(t, err, string(resp)) | |||
gssbzn
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Skip serverless cleanup on gov
Jira ticket: CLOUDP-211696
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments