Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-211696 Skip serverless cleanup on gov #2473

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Nov 27, 2023

Proposed changes

Skip serverless cleanup on gov

Jira ticket: CLOUDP-211696

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes changed the title CLOUDP-211696 Skip serverless on gov CLOUDP-211696 Skip serverless cleanup on gov Nov 27, 2023
@fmenezes fmenezes marked this pull request as ready for review November 27, 2023 11:25
@fmenezes fmenezes requested a review from a team November 27, 2023 11:26
@@ -85,6 +91,9 @@ func TestCleanup(t *testing.T) {
deleteAllDataFederations(t, cliPath, projectID)
})
t.Run("delete all serverless instances", func(t *testing.T) {
if IsGov() {
t.Skip()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main change

t.Parallel()
deleteOrgInvitations(t, cliPath)
})
t.Run("trying to org teams", func(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Run("trying to org teams", func(t *testing.T) {
t.Run("trying to delete org teams", func(t *testing.T) {

@@ -85,6 +91,9 @@ func TestCleanup(t *testing.T) {
deleteAllDataFederations(t, cliPath, projectID)
})
t.Run("delete all serverless instances", func(t *testing.T) {
if IsGov() {
t.Skip()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Skip()
t.Skip("serverless is not available on gov")

@fmenezes fmenezes requested a review from gssbzn November 27, 2023 14:54
@@ -215,7 +215,7 @@ func deleteServerlessInstanceForProject(t *testing.T, cliPath, projectID, cluste
deleteCmd := exec.Command(cliPath, args...)
deleteCmd.Env = os.Environ()
resp, err := deleteCmd.CombinedOutput()
require.NoError(t, err, resp)
require.NoError(t, err, string(resp))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks fro the drive-by on the error messages

@fmenezes fmenezes merged commit dc19992 into master Nov 27, 2023
16 checks passed
@fmenezes fmenezes deleted the CLOUDP-211696_skip_gov_serverless branch November 27, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants