SQL-2463: update release instructions #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terakilobyte
force-pushed
the
SQL-2463
branch
from
e6ef7f6
to
3703e74
Compare
bucaojit
reviewed
Nov 13, 2024
RELEASE.md
Outdated
| @@ -40,11 +42,17 @@ Close the release on JIRA, adding the current date (you may need to ask the SQL | |||
| Ensure you have the `master` branch checked out, and that you have pulled the latest commit from `mongodb/mongo-jdbc-driver`. | |||
|
|
|||
| #### Create the tag and push | |||
|
|
|||
| To determine which version of [`libmongosqltranslate`](https://github.com/10gen/mongosql-rs) to build with the release, the version | |||
There was a problem hiding this comment.
nit: The wording here sounds like I need to determine something where it's really means to specify the version for evergreen to download and include. Not sure the best way to reword it but here's a suggestion:
To specify which version of libmongosqltranslate that should be built with the release, include the version of libmongosqltranslate in the tag name. This is done by annotating the tag with libv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.