GODRIVER-1736 Fix deprecation notice formats #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divjotarora
force-pushed
the
godriver1736-deprecation-notices
branch
from
88c5326
to
5dc0d79
Compare
iwysiu
reviewed
Sep 16, 2020
iwysiu
reviewed
Sep 16, 2020
iwysiu
approved these changes
Sep 16, 2020
kevinAlbs
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these deprecations via
git grep "deprecated". After fixing the notices, I ran thestaticchecklinter against https://play.golang.org/p/3jPWZqPMt0H and ensured that all of the usages are marked as deprecated.If anyone wants to reproduce the results, run
go get honnef.co/go/tools/cmd/staticcheckto install the linter and copy/paste the the code from the playground link into a local script.I couldn't test deprecation warnings for struct fields due to dominikh/go-tools#607. This means that the
AuthenticateToAnythingandDeploymentClient options can't be tested because they don't have corresponding setter functions. To work around this forFindOptions,FindOneOptions, andIndexOptions, I deprecated both the struct field and the setter function.