Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-3307 Simplify MarshalValue and UnmarshalValue test case setup. #1914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GODRIVER-3307 Simplify MarshalValue and UnmarshalValue test case setup. #1914

wants to merge 1 commit into from

Conversation

matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented Jan 1, 2025 •
edited
Loading

GODRIVER-3307

Summary

  • Use keyed structs for all MarshalValue test cases to make them easier to read.
  • Use only struct literals instead of functions to define the MarshalValue test cases.
  • Don't use Marshal when testing MarshalValue to prevent bugs in Marshal from masking bugs in MarshalValue.
  • Remove unnecessary subtest nesting in TestMarshalValue.

Background & Motivation

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Jan 1, 2025
@mongodb-drivers-pr-bot mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

@matthewdale matthewdale force-pushed the godriver3307-refactor-test-marshal branch from e0ea3b6 to 702e571 Compare January 24, 2025 02:32
@matthewdale matthewdale marked this pull request as ready for review January 24, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewdale