Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create contribution guide #710

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Aug 27, 2024

Description

What is changing?

  • Remove ./test/bench/README.md
  • Move contents of deleted file to CONTRIBUTING.md
Is there new documentation needed for these changes?

N/A

What is the motivation for this change?

Easy access to relevant documentation.

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review August 27, 2024 17:49
README.md Outdated Show resolved Hide resolved
@dariakp dariakp self-assigned this Aug 29, 2024
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 29, 2024
@W-A-James W-A-James changed the title docs: merge readmes docs: create contribution guide Sep 3, 2024
@W-A-James W-A-James requested a review from dariakp September 3, 2024 21:32
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one spacing edit. Thanks for doing this!

CONTRIBUTING.md Show resolved Hide resolved
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 4, 2024
Co-authored-by: Daria Pardue <[email protected]>
@dariakp dariakp merged commit 8863915 into mongodb:main Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants